Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Rod culling is not working #294

Closed
yumunet opened this issue Sep 21, 2024 · 3 comments · Fixed by #295
Closed

End Rod culling is not working #294

yumunet opened this issue Sep 21, 2024 · 3 comments · Fixed by #295
Labels
TODO This is good and just needs to be implemented

Comments

@yumunet
Copy link

yumunet commented Sep 21, 2024

The top of end rod isn't culled. (0.23.1 or later)
Unlike #292, it doesn't work with Sodium. However, like the top of the fence culling, this happens in 0.23.1 or later, so it may be related.

Tests

World:

0.27.1

1.21.1, Fabric Loader 0.16.5 (Mods: Cloth Config 15.0.140, Fabric API 0.104.0)

It doesn't work (even with Sodium 0.6.0 beta1 or beta2).

0.23.1

1.20.4, Fabric Loader 0.16.5 (Mods: Cloth Config 13.0.138, Fabric API 0.97.2)

It doesn't work (even with Sodium 0.5.8).

0.22.1

1.20.4 (Same instance as above)

It works.

@yumunet
Copy link
Author

yumunet commented Sep 21, 2024

PS:
Sorry for submitting so many issues.
I found these issues while testing the effect of More Culling.

I know you are busy, so I don't mean to rush you.👍️

@FxMorin
Copy link
Owner

FxMorin commented Sep 21, 2024

@yumunet All good. We are working on fixing a lot of the issues and releasing a multiloader version.
So this is actually pretty good timing

@FxMorin FxMorin linked a pull request Sep 21, 2024 that will close this issue
@yumunet
Copy link
Author

yumunet commented Sep 26, 2024

Sorry, this is not fixed in v1.0.0-beta.1. (Both Fabric and NeoForge 21.1.61)

@FxMorin FxMorin reopened this Sep 26, 2024
@FxMorin FxMorin added the TODO This is good and just needs to be implemented label Sep 27, 2024
@1foxy2 1foxy2 closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO This is good and just needs to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants