Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The upward-facing side is sometimes incorrectly culled #321

Open
WinExp opened this issue Dec 7, 2024 · 8 comments
Open

The upward-facing side is sometimes incorrectly culled #321

WinExp opened this issue Dec 7, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@WinExp
Copy link

WinExp commented Dec 7, 2024

When I added some of the resource packs, I saw that some of the rail had the upward facing side incorrectly culled when Block State Culling is enabled.
image

@FxMorin
Copy link
Owner

FxMorin commented Dec 10, 2024

Can you include the resource packs you where using?

@WinExp
Copy link
Author

WinExp commented Dec 11, 2024

Probably not, this resource pack is a paid resource pack and sharing it requires the author's permission, which I don't have

@WinExp
Copy link
Author

WinExp commented Dec 11, 2024

I asked the author and he asked that the resource pack not be accessible to anyone else, can I send it to you via email?

@FxMorin
Copy link
Owner

FxMorin commented Dec 17, 2024

@WinExp I would rather you send me it on discord if possible. At fx.morin

@1foxy2
Copy link
Collaborator

1foxy2 commented Dec 23, 2024

the cullfaces of the model are set wrongly. basically "cullface": "direction" needs to be removed from elements which shouldn't be culled when that side is culled

@WinExp
Copy link
Author

WinExp commented Dec 25, 2024

But it looks like vanilla calculates whether the face is actually occluded or overlapping, so if moreculling does the same thing then shouldn't it have this problem?

@FxMorin
Copy link
Owner

FxMorin commented Dec 25, 2024

This is kinda true, but not really. Vanilla just culls really inefficiently.
We may look into doing some optimizations for this later, however I wouldnt expect that any time soon.

@1foxy2
Copy link
Collaborator

1foxy2 commented Dec 25, 2024

vanilla just have canOcclude which is false for rails and a lot of other blocks. this is what happens if you set it to true for rails
image

@FxMorin FxMorin added the bug Something isn't working label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants