Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cull paintings #85

Closed
muzikbike opened this issue Aug 19, 2022 · 1 comment
Closed

Cull paintings #85

muzikbike opened this issue Aug 19, 2022 · 1 comment
Labels
suggestion A suggestion, enhancement, feature or request

Comments

@muzikbike
Copy link

The mod already implements culling for item frames, an entity which cannot have faces culled in vanilla. Paintings, another entity, are a prime candidate for something to do next: by design, not only their back faces, but every face that isn't their front will always be flush against a block face, making them impossible to view if there happens to be a block occluding that face. So having these faces be culled should probably be a performance boost as well.
2022-08-18_16 42 38
2022-08-18_16 42 43
2022-08-18_16 42 51

Also, while I haven't tested this with the mod, in vanilla paintings appear to have completely redundant internal faces when larger than 1x1, so having these faces also be removed would likely be beneficial since those can never be seen at all without clipping inside of the painting.
Likewise, it'd probably be a good idea for the edges of paintings to cull the edges of other paintings, if that's even possible...

@FxMorin FxMorin added the suggestion A suggestion, enhancement, feature or request label Dec 15, 2022
@1foxy2 1foxy2 closed this as completed in dbfde46 Jan 5, 2025
@1foxy2
Copy link
Collaborator

1foxy2 commented Jan 5, 2025

Added culling for back and internal faces, however i dont think culling paintings against other paintings is possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion A suggestion, enhancement, feature or request
Projects
None yet
Development

No branches or pull requests

3 participants