Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falling block dupe fix #8

Closed
angrynerd opened this issue May 24, 2021 · 10 comments
Closed

Falling block dupe fix #8

angrynerd opened this issue May 24, 2021 · 10 comments

Comments

@angrynerd
Copy link

The falling block dupe fix seems to be active even when its set to false. I set it to false in the config and manually on the server and the sand generator that was previously working for one of my members no longer does. I apologize for reporting so many issues, but they are happening so i figure its better to mention them.

@angrynerd
Copy link
Author

angrynerd commented May 24, 2021

Noted it seems to work when none of the fixes in this mod are applied. I am currrently unable to test which one specifically is breaking it. To be clear the piston dupe fix and rail dupe fixes are also disabled rn. I will updated this when i am able to.

@angrynerd
Copy link
Author

Ok so after testing this issue is caused by the blockCollisionCheckFix being set to true. This breaks endportal falling entity dupers.

@FxMorin
Copy link
Owner

FxMorin commented May 24, 2021

LOL, so fixing the collision system causes falling blocks to not dupe. Wow that's funny, ill make a condition for it

@FxMorin
Copy link
Owner

FxMorin commented May 24, 2021

Fixed in v0.0.4

@FxMorin FxMorin closed this as completed May 24, 2021
@angrynerd
Copy link
Author

Ok I just tested this fix and now it seems its actually worse now the sand duping machine doesnt function even when all of the rules are turned off.

@FxMorin
Copy link
Owner

FxMorin commented May 25, 2021

Have you tested this same duper without carpet-fixes?
oh oops my bad, ya ill fix it

@FxMorin FxMorin reopened this May 25, 2021
@FxMorin
Copy link
Owner

FxMorin commented May 25, 2021

Ok fix for this will be out in tomorrow's release also. I'll keep the issue open this time tho

@angrynerd
Copy link
Author

Can confirm that this is fixed for blockCollisionCheckFix, however the incorrectBounceLogicFix rule now breaks slime block based sand duping. The sand goes into the end portal rather than staying in the over world and then duping into the end. fully replicating the behavior of the actual falling entity fix rather than the collision fix which still left the blocks in the overworld but didnt dupe the entities. for reference this is the specific machine in use for testing https://youtu.be/Qiq_cHQVM_I. This may be considered as intended behavior as im assuming the sand entities are bouncing off the slime instead of being stuck to them.

@FxMorin
Copy link
Owner

FxMorin commented May 29, 2021

Yup this is intended behavior.

@FxMorin FxMorin closed this as completed May 29, 2021
@FxMorin
Copy link
Owner

FxMorin commented May 29, 2021

AAAAAAHHHH That was a shulkercraft video, my eye's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants