Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Outdated TODO: ADD PoolSkill.skillLevel code #11334

Closed
1 task
mnigh opened this issue Aug 22, 2024 · 0 comments · Fixed by #11335
Closed
1 task

♻️ Outdated TODO: ADD PoolSkill.skillLevel code #11334

mnigh opened this issue Aug 22, 2024 · 0 comments · Fixed by #11335
Assignees
@mnigh
Labels
debt Refactor or improve existing code.

Comments

@mnigh
Copy link
Contributor

mnigh commented Aug 22, 2024

♻️ Debt

Code is no longer relevant and line can be removed.

🕵️ Details

#11186 (reply in thread)

🙋‍♀️ Proposed Solution

Remove code.

gc-digital-talent/apps/web/src/components/AssessmentResultsTable/AssessmentResultsTable.tsx

Line 310 in e97c510

{/* TODO: ADD PoolSkill.skillLevel here --> {original.poolSkill.type === PoolSkillType.Essential && <span>{intl.formatMessage(getTechnicalSkillLevel(original.poolSkill.skillLevel))}</span> */}

✅ Acceptance Criteria

  • AssessmentResultsTable.tsx#L310 removed from codebase
@mnigh mnigh added the debt Refactor or improve existing code. label Aug 22, 2024
@mnigh mnigh self-assigned this Aug 22, 2024
@mnigh mnigh mentioned this issue Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnigh mnigh

Labels
debt Refactor or improve existing code.
Projects
GC Digital Talent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Debt] Removes outdated code GCTC-NTGC/gc-digital-talent
1 participant
@mnigh