Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Mutation updateUserTeamRoles deprecated and broken #11350

Closed
1 task
mnigh opened this issue Aug 23, 2024 · 0 comments · Fixed by #11353
Closed
1 task

♻️ Mutation updateUserTeamRoles deprecated and broken #11350

mnigh opened this issue Aug 23, 2024 · 0 comments · Fixed by #11353
Assignees
@mnigh
Labels
debt Refactor or improve existing code.

Comments

@mnigh
Copy link
Contributor

mnigh commented Aug 23, 2024

♻️ Debt

The mutation updateUserTeamRoles is deprecated and broken.

🕵️ Details

gc-digital-talent/api/graphql/schema.graphql

Lines 1684 to 1686 in 90bfd94

updateUserTeamRoles(
teamRoleAssignments: UpdateUserTeamRolesInput! @spread
): Team @guard @can(ability: "assignTeamMembers", find: "teamId")

🙋‍♀️ Proposed Solution

  1. Delete file api/tests/Feature/Mutation/UpdateUserTeamRolesTest.php
  2. Remove updateUserTeamRoles mutation from api/graphql/schema.graphql

✅ Acceptance Criteria

  • no references to updateUserTeamRoles mutation in codebase
@mnigh mnigh added the debt Refactor or improve existing code. label Aug 23, 2024
@mnigh mnigh self-assigned this Aug 23, 2024
@mnigh mnigh mentioned this issue Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnigh mnigh

Labels
debt Refactor or improve existing code.
Projects
GC Digital Talent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Debt] Removes mutation updateUserTeamRoles GCTC-NTGC/gc-digital-talent
1 participant
@mnigh