Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change URL for unsupported iOS versions #21

Open
NiklasMerz opened this issue Sep 24, 2021 · 6 comments
Open

Don't change URL for unsupported iOS versions #21

NiklasMerz opened this issue Sep 24, 2021 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@NiklasMerz
Copy link
Collaborator

If this plugin just don't change the URL in the method window.WebviewProxy.convertProxyUrl on iOS 12, 11..., it will work.

Originally posted by @JuHaYK in #20 (comment)

@NiklasMerz NiklasMerz added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 24, 2021
@JuHaYK
Copy link

JuHaYK commented Sep 24, 2021

Do you know how to detect that iOS version is less than 13?

@NiklasMerz
Copy link
Collaborator Author

If you have a look the WebktiProxy.js file of this plugin you can see that I implemented a check for the variable window.CDV_ASSETS_URL. One thing to make sure is that the app runs with a custom scheme. The plugin won't work when the assets are loaded from file:.

Possibly there are some JS variables that only exists on new versions. Otherwise you could check WebKit versions or features. Not entirely sure. I might look for other options.

@JuHaYK
Copy link

JuHaYK commented Sep 27, 2021

Ok, if we don't change URL on unsupported iOS versions, we have again problems with cookie...
It's not possible to support iOS 11 and 12?

@NiklasMerz
Copy link
Collaborator Author

Yes I don't think it is possible to use this plugin on iOS 11 and 12. For these iOS versions you most likely need to find other workarounds for cookie issues.

@JuHaYK
Copy link

JuHaYK commented Oct 1, 2021

Can you explain the problem why it is not possible to support iOS 11 and 12? Can I perhaps help?

@JuHaYK
Copy link

JuHaYK commented Oct 11, 2021

First problem is, that body (on line 28) always "nil" is. Can you help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants