Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percolation tests are slow #187

Closed
stefsmeets opened this issue Nov 20, 2023 · 1 comment · Fixed by #188
Closed

Percolation tests are slow #187

stefsmeets opened this issue Nov 20, 2023 · 1 comment · Fixed by #188
Assignees

Comments

@stefsmeets
Copy link
Contributor

I noticed tests are much slower after #178. It seems like the percolation test takes the full dataset, and therefore takes over 40s to complete. I think we should use a reduced dataset for this.

======================== slowest 10 durations ========================
39.53s call     tests/integration/transitions_test.py::test_transitions_find_best_perc_path
5.73s setup    tests/integration/shape_test.py::test_shape
5.59s setup    tests/integration/plot_test.py::test_shape[png]
2.78s setup    tests/integration/rdf_test.py::test_rdf
2.23s setup    tests/integration/plot_test.py::test_rdf[png]
1.76s call     tests/integration/plot_test.py::test_jumps_3d_animation[png]
1.26s call     tests/integration/plot_test.py::test_jumps_3d[png]
1.12s call     tests/integration/trajectory_test.py::test_volume_to_structure_cluster
@stefsmeets
Copy link
Contributor Author

On a side note, this also means the algorithm itself is quite slow. Is there anything we can do about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant