Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocorrelation should use unit vectors #290

Closed
tfamprikis opened this issue Mar 18, 2024 · 0 comments · Fixed by #291
Closed

autocorrelation should use unit vectors #290

tfamprikis opened this issue Mar 18, 2024 · 0 comments · Fixed by #291

Comments

@tfamprikis
Copy link
Contributor

tfamprikis commented Mar 18, 2024 •
edited
Loading

current implementation depends on how Orientations was created. should instead first always normalize to unit vectors so that the resulting function always starts from 1 (see below)

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to select MSD algorithm GEMDAT-repos/GEMDAT
1 participant
@tfamprikis