Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of remap_restarts processing of time-invariant parameters in restart files #669

Closed
gmao-rreichle opened this issue Nov 16, 2022 · 1 comment
Assignees
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup

Comments

@gmao-rreichle
Copy link
Contributor

There appears to be obsolete reading of data in remap_restarts processing:

Specifically, the time-invariant parameters that are read in subroutine read_shared_nc4() should not be needed.

When Catch[CN] restart file is remapped from one resolution or bcs version to another resolution or bcs version, the time-invariant parameters in the target restart file must come directly from the target bcs. The time-invariant parameters in the source restart file should not be remapped.

The same probably applies to CatchmentCNRst.F90.

See also items 3. and 4. in #618 (comment)

cc: @weiyuan-jiang @biljanaorescanin

@gmao-rreichle gmao-rreichle added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup labels Nov 16, 2022
@gmao-rreichle
Copy link
Contributor Author

Addressed in #670. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup
Projects
None yet
Development

No branches or pull requests

2 participants