Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up nm to m conversion in GOCART2G #73

Closed
mathomp4 opened this issue Aug 6, 2021 · 1 comment
Closed

Clean up nm to m conversion in GOCART2G #73

mathomp4 opened this issue Aug 6, 2021 · 1 comment
Labels
Refactoring Code restructuring for clarity/efficiency SomeDayMaybe An issue that should be considered in the future, maybe.

Comments

@mathomp4
Copy link
Member

mathomp4 commented Aug 6, 2021

wavelengths_diagmie is still declared as integer:

integer, allocatable, dimension(:) :: wavelengths_diagmie

which is inconsistent with self%wavelengths_profile and self%wavelengths_vertint (real).

I would still recommend including changes from PR #65 into this branch to address this issue and streamline the code. For example, conversion from nm to m should be done only once (see https://github.com/GEOS-ESM/GOCART/pull/65/files#diff-682724d291af0ad213c4e1b2ffa97156de4989543290b60bf362adfa98e3d8da):

! Convert input wavelengths from nm to m for internal use
self%wavelengths_profile = 1.e-09 * self%wavelengths_profile
self%wavelengths_vertint = 1.e-09 * self%wavelengths_vertint
wavelengths_diagmie = 1.e-09 * wavelengths_diagmie
! Set wavelengths in universal config

Originally posted by @rmontuoro in #68 (comment)

@amdasilva
Copy link
Collaborator

This is less of an issue now since these calculations are now done at array level with the refactoring of the Mie calculations.

@amdasilva amdasilva added Refactoring Code restructuring for clarity/efficiency SomeDayMaybe An issue that should be considered in the future, maybe. labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Code restructuring for clarity/efficiency SomeDayMaybe An issue that should be considered in the future, maybe.
Projects
None yet
Development

No branches or pull requests

2 participants