Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_scripts failing by small deltas #138

Closed
josephdviviano opened this issue Oct 4, 2023 · 2 comments
Closed

test_scripts failing by small deltas #138

josephdviviano opened this issue Oct 4, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@josephdviviano
Copy link
Collaborator

=============================================== short test summary info ===============================================
FAILED test_scripts.py::test_hypergrid[8-2] - assert 0.0008832142921164632 < 0.00073
FAILED test_scripts.py::test_hypergrid[16-4] - assert 2.456717993482016e-05 < 2.45e-05
FAILED test_scripts.py::test_discreteebm[0.1-2] - assert 0.002971753478050232 < 0.0026
================================ 3 failed, 9 passed, 2 warnings in 1225.99s (0:20:25) =================================

I'm not sure if we should actually worry about this (or rather whether this is just due to the seed not being applied to enough RNGs in the scripts -- i.e., we don't seed numpy or random).

@josephdviviano josephdviviano self-assigned this Oct 4, 2023
@josephdviviano josephdviviano added the bug Something isn't working label Oct 4, 2023
@saleml
Copy link
Collaborator

saleml commented Oct 5, 2023

Not really harmful. Discrepancies in gpu/cpu/OS I believe. The scripts still run fine on my laptop actually.

To avoid failure, let's add more seeds, and a set a larger epsilon for the gap between obtained result and expected result ?

@josephdviviano
Copy link
Collaborator Author

Seeds added and tolerances increased in #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants