Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay buffer broken in train_hypergrid.py #168

Closed
josephdviviano opened this issue Feb 27, 2024 · 0 comments · Fixed by #174
Closed

Replay buffer broken in train_hypergrid.py #168

josephdviviano opened this issue Feb 27, 2024 · 0 comments · Fixed by #174
Assignees
@josephdviviano @saleml
Labels
bug Something isn't working

Comments

@josephdviviano
Copy link
Collaborator

When a replay buffer is being used, the gflownet will not converge, but will if there is no replay buffer. I suspect this has something to do with off-policy logic changes that were introduced here:

#147
@josephdviviano josephdviviano added the bug Something isn't working label Feb 27, 2024
@saleml saleml mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephdviviano josephdviviano

@saleml saleml

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix off policy GFNOrg/torchgfn
2 participants
@josephdviviano @saleml