Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect formulation of Stieltjes transform of re-scaled MP density #3

Open
vnguyen01 opened this issue Sep 6, 2020 · 1 comment

Comments

@vnguyen01
Copy link

I might be mistaken, but I think the code on https://github.com/GGiecold/pyRMT/blob/master/pyRMT.py#L452-L455 does not reflect what is written in the green Box 1. on the last page of one of the referenced papers: https://www.cfm.fr/assets/ResearchPapers/2016-Cleaning-Correlation-Matrices.pdf

I think that
gmp = z + sigma_2 * (q - 1) - np.sqrt((z - lambda_N) * (z - lambda_plus))
should be
gmp = z + sigma_2 * (q - 1) - np.sqrt(z - lambda_N) * np.sqrt(z - lambda_plus)

@Matthieusalor
Copy link

Matthieusalor commented Oct 15, 2020

Hi,
np.sqrt(x) * np.sqrt(y) = np.sqrt(x*y).
Therefore this do not change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants