Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Change media type of GeoJSON response #199

Merged
merged 1 commit into from
Oct 25, 2021
Merged

API: Change media type of GeoJSON response #199

merged 1 commit into from
Oct 25, 2021

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Oct 25, 2021 •
edited
Loading

Description

The media type for GeoJSON text is "application/geo+json".

Corresponding issue

Closes #133

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
    - [ ] I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub
API: Change media type of GeoJSON response
c8c75df 
The media type for GeoJSON text is "application/geo+json".
@matthiasschaub matthiasschaub added the waiting for review This pull request urgently needs a code review label Oct 25, 2021
@joker234 joker234 removed the waiting for review This pull request urgently needs a code review label Oct 25, 2021
@joker234 joker234 added this to the Release 0.7.0 milestone Oct 25, 2021
joker234
joker234 reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor code smell you could solve. https://sonarcloud.io/project/issues?branch=PR-199&id=ohsome-quality-analyst&open=AXy2RiITNFiucSIUYMdc&resolved=false&sinceLeakPeriod=true&types=CODE_SMELL

@matthiasschaub matthiasschaub merged commit 9760666 into main Oct 25, 2021
@matthiasschaub matthiasschaub deleted the api-response-media-type branch October 25, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.7.0
Development

Successfully merging this pull request may close these issues.

API: Change media type of GeoJSON response
2 participants
@matthiasschaub @joker234