rename layer ideal_vgi_infrastructure to basic_infrastructure #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
306
to
310
| basic_infrastructure: | ||
| name: Basic Infrastructure | ||
| description: Objects related to infrastructure | ||
| endpoint: elements/length | ||
| filter: (aerialway=* or aeroway=* or highway=* or power=* or railway=* or telecom=*) and geometry:line |
There was a problem hiding this comment.
@SlowMo24 what would be a good name for this layer? Basic Infrastructure is a bit broad of a term is it not? Because its only lines, so infrastructures which are polygon or points like power boxes are not included in this layer.
Maybe a fitting name would be Infrastructure Lines? Also is there a source we can point to?
There was a problem hiding this comment.
Yes, Infrastructure Lines sounds good. There is no source to point to except https://gitlab.gistools.geog.uni-heidelberg.de/giscience/ideal-vgi/osm-element-vectorisation/-/blob/main/src/osm_element_vectorisation/resources/misc/tagGrouping.json
Gigaszi
added
the
brainstorming
matthiasschaub
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename layer ideal_vgi_infrastructure to basic_infrastructure.
Corresponding issue
Closes #259
New or changed dependencies
Checklist
main(e.g. throughgit rebase main)Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using
~...~) and remove their checkboxes.