Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more than 4 columns in the csv file in CsvGraphStorageBuilder #1436

Closed
redfrexx opened this issue May 11, 2023 · 4 comments · Fixed by #1821
Closed

Add support for more than 4 columns in the csv file in CsvGraphStorageBuilder #1436

redfrexx opened this issue May 11, 2023 · 4 comments · Fixed by #1821

Comments

@redfrexx
Copy link
Member

redfrexx commented May 11, 2023

Requests with extra_info": ["csv"] fail because the csv file contains more than 4 columns. Can we add support for more than 4 columns?

@redfrexx redfrexx changed the title Add support for more than 5 columns in the csv file in CsvGraphStorageBuilder Add support for more than 4 columns in the csv file in CsvGraphStorageBuilder May 11, 2023
@MichaelsJP
Copy link
Member

@redfrexx Please elaborate a bit more in detail why this change is needed, for documentation purposes. Thanks :)

@redfrexx
Copy link
Member Author

For the HEAL routing client we provide 5 points in time: now and 4 timestamps of a typical heat day (10am, 1 pm, 4pm and 7pm). So that makes 5 columns in the csv file.

Ideally and if possible with reasonable effort, it would be good if even up to 8 or 10 columns could be supported to conduct further route analyses, e.g. provide heat indices for several months to see how the detours evolve across the year compared to the fastest route.

@sfendrich
Copy link
Contributor

I have looked through the code and didn't find an indication that this limit is in place. Can you provide some details that show that this limit exists?

@redfrexx
Copy link
Member Author

Request work, but when adding extra_info: ["csv"] to the request, I get the error:

ERROR [routing.RoutingProfile] - java.lang.ArrayIndexOutOfBoundsException: arraycopy: last destination index 18 out of bounds for byte[4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Awaiting release
Development

Successfully merging a pull request may close this issue.

3 participants