Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate directions 'options' object on backend #154

Closed
nilsnolde opened this issue Mar 20, 2018 · 4 comments
Closed

Evaluate directions 'options' object on backend #154

nilsnolde opened this issue Mar 20, 2018 · 4 comments

Comments

@nilsnolde
Copy link
Contributor

The options object should be evaluated server-side. Now, it simply fails silently, when a parameter is specified in the wrong way, i.e. maximumspeed instead of maximum_speed, and returns the route without an error.

@MichaelsJP if and when you have the ressources. Or coordinate with @Elli96 if that makes sense. No urgency here though. But let's keep it in mind for 4.6 the latest.

@rabidllama
Copy link
Contributor

I am moving this to 4.7 as we will have more resources available in the next couple of months

@rabidllama rabidllama modified the milestones: 4.6, 4.7 Jul 6, 2018
@TimMcCauley TimMcCauley assigned rabidllama and unassigned Elli96 Aug 2, 2018
@TimMcCauley
Copy link
Contributor

Related to #233 - will be done then.

@MichaelsJP MichaelsJP removed their assignment Sep 3, 2018
@rabidllama
Copy link
Contributor

Lets put this on hold then until v5

@rabidllama rabidllama modified the milestones: 4.7, 5.0 Oct 12, 2018
@rabidllama
Copy link
Contributor

So in the newer API which will be released in 5.0, mismatched values/parameters should always return an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants