Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker nightly build #1686

Closed
1 task done
TheGreatRefrigerator opened this issue Feb 13, 2024 · 0 comments · Fixed by #1689
Closed
1 task done

fix docker nightly build #1686

TheGreatRefrigerator opened this issue Feb 13, 2024 · 0 comments · Fixed by #1689

Comments

@TheGreatRefrigerator
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Currently, docker nightly images get built & published to dockerhub for basically every PR change, which consumes quite some quota.
This is neither a nightly build nor is it consistent, as the content of the image changes with the branch currently being built.

Proposed solution

Do normal nightly build if anything changed in main.
Similar to e.g. https://github.com/libgit2/libgit2/blob/main/.github/workflows/nightly.yml

Additional context

If we still want to do docker image builds for PRs we should do it differently

Forum Topic Link

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Awaiting release
Development

Successfully merging a pull request may close this issue.

2 participants