-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make typeFilter accept arbitrary sets of OSMType #157
Conversation
i.e. when calling it multiple times, the filter is further restricted, not replaced with the last set of types
oshdb-api/src/test/java/org/heigit/bigspatialdata/oshdb/api/tests/TestOSMDataFilters.java
Show resolved
Hide resolved
9648659
to
9640719
Compare
thanks for the review @FabiKo117. The only reason why I was still reluctant to merge this is that it technically did break the way the method But, on the other hand, according to our documentation (https://github.com/GIScience/oshdb/blob/master/documentation/manual/filters.md) the current (v0.5.5) code is actually wrong because it states the following which is currently not the case for the
I'm changing this to a bugfix (from a breaking change), if you're ok with that?! |
I see.. from that point of view it is then actually a bugfix indeed. |
This changes osm-type filters to
EnumSet
s).osmType(EnumSet.noneOf(OSMType.class))
).Checklist