Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a 'set-optimal-orf' function #2129

Closed
2 tasks done
nathandunn opened this issue Apr 10, 2019 · 1 comment · Fixed by #2609
Closed
2 tasks done

provide a 'set-optimal-orf' function #2129

nathandunn opened this issue Apr 10, 2019 · 1 comment · Fixed by #2609

Comments

@nathandunn
Copy link
Contributor

nathandunn commented Apr 10, 2019

From @strumpfe

  • should be a drop-down option
  • should be a default configuration as well

To me the logic of how initiation codons are handled is wrong. The current behaviour is for a methionine to be used as a start codon only if there is an upstream (5’) stop codon in the exon feature. See figure below where AFUN008255-LAWSON-00001 is the result of promoting the gff3 match span and AFUN008255-LAWSON-00002 is what I’d actually like to see. I think the default prediction should have a start codon with partial predictions that lack a start having to be asserted via the ‘Set Translation Start’ option. At the moment the opposite happens and I spend a lot of time resetting the start codon e.g. when you duplicate a transcript to make an alternative isoform if there are no stop codons in the 5’ UTR then Apollo with extend the exon and you need to reset the start codon. This scenario is the primary issue our QC picks up from community annotations where users promote a reference gene model to modify it but fail to notice that Apollo has changed the 5’ end to extend into what was defined as 5’ UTR.

Even if this cannot be the default behaviour then maybe we could repurpose or add and analogous function to the ‘Set Longest ORF’ option.

The aim is to have Apollo promote complete predictions (ATG->STOP) as the default and not [A-Y]->STOP.

@nathandunn nathandunn added this to the 2.4.0 milestone Apr 10, 2019
@nathandunn
Copy link
Contributor Author

image

@nathandunn nathandunn modified the milestones: 2.4.0, 2.4.1 Apr 19, 2019
@nathandunn nathandunn modified the milestones: 2.4.1, 2.4.2 Jul 5, 2019
@nathandunn nathandunn modified the milestones: 2.4.2, 2.5.0 Sep 5, 2019
@nathandunn nathandunn removed this from the 2.6.0 milestone Apr 9, 2021
nathandunn added a commit that referenced this issue Apr 14, 2021
@nathandunn nathandunn mentioned this issue Apr 14, 2021
7 tasks
nathandunn added a commit that referenced this issue Apr 15, 2021
* fixes #2129

* updated menu

* fixed linting error

* updated

* reformatted and synced the apis

* removed redundant method

* updated javadoc

* everything seems to be working now

* cleaned up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant