Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory leak #3596

Closed
cmdcolin opened this issue Mar 20, 2023 · 4 comments
Closed

Possible memory leak #3596

cmdcolin opened this issue Mar 20, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@cmdcolin
Copy link
Collaborator

If you look at a 1000 genome vcf and continuously side scroll, the amount of memory consumed can go up to high levels on the main thread (not web worker). The 1000 genomes vcf's already allocate a lot of memory due to serialization of the genotypes field, but the continuing increase in memory consumption seems odd. It can eventually go down, but the memory remains high and seems like it could be a bug somehow?

It's possible this is not a true memory leak, but i suppose even if not, the amount of memory used for browsing 1000 genomes type data should be brought under control e.g. by avoiding serialization of the genotype field

Example

Memory panel of devtools, showing >2gb consumption, tested in v1.3.0 just for checking if it affects older and newer versions

image

Allocation sampling panel, showing a large amount of memory dominated by one long shallow rectangle

Screenshot from 2023-03-20 09-35-03

The code that it points to for that rectangle

Screenshot from 2023-03-20 09-35-11

I was not sure why that particular bit of code would be "holding" the memory but i'm also not too familiar with memory profiling

@cmdcolin cmdcolin added the bug Something isn't working label Mar 20, 2023
@cmdcolin
Copy link
Collaborator Author

@cmdcolin
Copy link
Collaborator Author

might actually be better in newer versions vs the 1.3.0 that i tested

@cmdcolin
Copy link
Collaborator Author

it's really tricky to properly tell if any memory leak exists. wanted to try out https://github.com/plasma-umass/BLeak but couldn't get set up plasma-umass/BLeak#68 (comment)

@cmdcolin
Copy link
Collaborator Author

maybe can close until confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant