Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to accept a different md5 hash than the one in the appliance file. #1246

Closed
AJNOURI opened this issue Dec 28, 2017 · 5 comments
Closed
Assignees
Milestone

Comments

@AJNOURI
Copy link
Contributor

AJNOURI commented Dec 28, 2017

Lot's of issues related to md5sum required in the appliance files and the md5sum of the files the users use (Whatever the source).

Can we somehow allow during appliance import to change the md5sum? Of course we can Warn the users of the security risks to have a hash different fro the original.

@ziajka ziajka added the Bug label Dec 28, 2017
@ziajka ziajka added this to the 2.1.2 milestone Dec 28, 2017
@ziajka ziajka added Enhancement and removed Bug labels Dec 28, 2017
@grossmj grossmj modified the milestones: 2.1.2, 2.1.3 Jan 8, 2018
@grossmj grossmj modified the milestones: 2.1.3, 2.2, 2.1.4 Jan 14, 2018
@grossmj grossmj modified the milestones: 2.1.4, 2.2 Jan 24, 2018
@ziajka
Copy link
Contributor

ziajka commented Jan 25, 2018

Ref. GNS3/gns3-gui#2404

@AJNOURI above is PR with this change. During import of appliance you have "Allow custom files" checkbox (upload files time). However there is a question. Is it more beneficial than just creation new version of appliance? Potentially it can be really risky to upload file with different MD5.

@ziajka
Copy link
Contributor

ziajka commented Jan 25, 2018

@grossmj your thoughts are welcome here.

@grossmj
Copy link
Member

grossmj commented Jan 25, 2018

However there is a question. Is it more beneficial than just creation new version of appliance? Potentially it can be really risky to upload file with different MD5.

I think it is fine with a warning. The problem with creating new version of an appliance is it takes some time and knowledge, this is easy for us but not necessarily for beginners.

@ziajka ziajka closed this as completed Jan 26, 2018
@AJNOURI
Copy link
Contributor Author

AJNOURI commented Feb 6, 2018

Sorry @ziajka for the late reply.
I don't know for what reasons, md5 hashes of lots of appliance (already existing versions) don't match with the ones in the file, eventhough the images are the originals.
So this will make it easier for beginners to try these appliances without the need to dig into creating new appliances or new versions and we hope to balance the security risk with the warning.

@altmind
Copy link

altmind commented Aug 9, 2019

I dont understand this dialog "This is not the correct file. Do you want to accept it at your own risk?"
Clicking yes does not import the image, so why asking? Is it a gui problem?

GNS 2.1.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants