Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 #513

Open
kkoumantaros opened this issue Mar 26, 2024 · 2 comments
Open

Add support for PHP 8 #513

kkoumantaros opened this issue Mar 26, 2024 · 2 comments

Comments

@kkoumantaros
Copy link

Adding support for php8 would be useful as anything bellow 7.2 seems to be EOL

@gregcorbett gregcorbett mentioned this issue Apr 22, 2024
4 tasks
@gregcorbett
Copy link
Member

Thanks for this @kkoumantaros, we didn't have a standalone issue to track this - only #337, which is much broader in scope.

I've posted a update in #337 to clarify how the various draft/open PRs fit together to update various parts of the codebase.

Some work has been done to support PHP8: https://github.com/gregcorbett/gocdb/commits/php8/. IIRC, updating to PHP 8 will require us to update the version of PHPUnit we use - which will require some refactoring of the unit tests themselves and the branch php8 gets us some of the way there. I will have to refresh my understanding of the exact situation here.

As Rocky 8 has both module for PHP 7.4 and 8.0 - we may aim to support PHP 8.0+ only, dropping support for PHP 7.4.

@gregcorbett gregcorbett changed the title suppor for php 8 Add support for PHP 8 Apr 22, 2024
@kkoumantaros
Copy link
Author

As PHP 7.4 is EOL I would suggest you focus on PHP 8 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants