Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to think of a model that works with the security implementations of github #3

Closed
GRASBOCK opened this issue Jul 7, 2024 · 1 comment

Comments

@GRASBOCK
Copy link
Owner

GRASBOCK commented Jul 7, 2024

I want to create a purely client side app. Now I am blocked by a CORS error. An issue for this is open since 2015. Makes sense, that they don't want me to expose the github app client secret.

PKCE as an alternative is not supported by github; see the docs. People want it, but it might take some time to get it.

PKCE is supported by gitlab.

I don't want to have a proxy running, so the only authentication flows I am left with are

  • personal access token; it has quite a lot of friction and is only on a per user basis (one cannot share a link to the visualization). It is a one time thing though.
  • device flow; also friction, because it requires authenticating by writing a code and the app also needs to poll until authorized...
@GRASBOCK
Copy link
Owner Author

The same problem happens with device flow authentication. Access tokens are the only way this can be done purely client side.

@GRASBOCK GRASBOCK closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant