Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberValidation forces minimums and maximums to be floats #346

Open
svix-jplatte opened this issue Oct 7, 2024 · 1 comment
Open

NumberValidation forces minimums and maximums to be floats #346

svix-jplatte opened this issue Oct 7, 2024 · 1 comment

Comments

@svix-jplatte
Copy link

NumberValidation currently has all its fields as Option<f64>. That means serializing a schema for an integer with one or multiple of these limits always has a .0 suffix.

Would you accept a PR that changes these f64s to serde_json::Numbers?
@svix-jplatte
Copy link
Author

Gentle ping @GREsau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@svix-jplatte