New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode vars_parity in UserVariables files #204

Open

KAClough opened this issue Jan 7, 2022 · 0 comments

Assignees

Labels

Member

KAClough commented Jan 7, 2022 •

edited by mirenradia

Loading

It would be much nicer and less error prone to implement the vars_parity in the UserVariables (and DiagnosticVariables) namespaces, e.g.

namespace UserVariables
{
static constexpr char const *variable_names[NUM_VARS] = {
    "psi",

    "V1_0",    "V2_0",  "V3_0",  "U_0",

    "phi_0",   "Pi_0",

    "K_0",

    "A11_0",   "A12_0", "A13_0", "A22_0", "A23_0", "A33_0"};

static constexpr std::array<int, NUM_VARS> const vars_parity = {
    0, 1, 2, 3, 0, 0, 0, 0, 0, 4, 6, 0, 5, 0};

} // namespace UserVariables

And have the Boundary conditions default to these values. However, it seems inevitable that it would break existing code.

KAClough self-assigned this

KAClough added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment