You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The boundary condition code is in a bit of a mess. I haven't tested anything beyond Sommerfeld and reflective conditions but I think these may be the only working non-periodic ones.
In the Sommerfeld case, we now apply the condition within the valid domain unlike for GRChombo (where we apply it in the ghost cells exterior to the valid domain). AMReX can handle extrapolating conditions but this is then applied in the exterior ghost cells (we actually do this currently in the Sommerfeld case to avoid NaNs not that it should affect anything). Is this OK or, for consistency, if using mixed BCs, do we need to apply the extrapolation in the same cells as for Sommerfeld? What do you think @KAClough?
The existing code should also be refactored/renamed to make it clear these are separate and in addition to AMReX's boundary condition code.
The text was updated successfully, but these errors were encountered:
Yes this is a good point. For the mixed BCs it would need to be consistent. I think it would be nice to have the option to use the AMReX BCs but also I do like being able to have the framework to create our own bespoke ones. So I would say for ours we should consistently apply them within the domain.
The boundary condition code is in a bit of a mess. I haven't tested anything beyond Sommerfeld and reflective conditions but I think these may be the only working non-periodic ones.
In the Sommerfeld case, we now apply the condition within the valid domain unlike for GRChombo (where we apply it in the ghost cells exterior to the valid domain). AMReX can handle extrapolating conditions but this is then applied in the exterior ghost cells (we actually do this currently in the Sommerfeld case to avoid NaNs not that it should affect anything). Is this OK or, for consistency, if using mixed BCs, do we need to apply the extrapolation in the same cells as for Sommerfeld? What do you think @KAClough?
The existing code should also be refactored/renamed to make it clear these are separate and in addition to AMReX's boundary condition code.
The text was updated successfully, but these errors were encountered: