Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-validation for total_amount_expended < limit #3869

Closed
tadhg-ohiggins opened this issue May 21, 2024 · 3 comments
Closed

Add cross-validation for total_amount_expended < limit #3869

tadhg-ohiggins opened this issue May 21, 2024 · 3 comments
Assignees

Comments

@tadhg-ohiggins
Copy link
Contributor

Following from #3769, we may also need to catch the case where total_award_expended is some invalid amount.

We've primarily seen this in cases where there were no federal awards and total_award_expended is zero, but should we just reject if the total is below some limit, and should that limit be the same as the limit we ask submitters about in the initial steps? (Currently this is $750,000.)

@jadudm
Copy link
Contributor

jadudm commented May 22, 2024

I believe this is safe.

There is ambiguous policy floating around the world that suggests that, for some entities, they can/must submit at a lower threshold. This has never been resolved. Therefore, we will disregard it as an "unknown/unknown."

I think it is safe to set this to the threshold. If someone thinks they should be able to submit with a spend below the SA threshold, and we prevent them... they will reach out to us.

@jperson1
Copy link
Contributor

jperson1 commented Aug 7, 2024

Moving this to "Blocked" for now. See the relevant Slack thread for why, but TL;DR:

Expenditures and reimbursements count against each other. If that brings the record below the threshold, we don't want to block it. How can we detect that, and is it our place to block a submission when the user has attested early in the process that they are above the threshold?

@jperson1
Copy link
Contributor

This can be superseded by #4198, as changing and enforcing the dollar threshold (while still allowing pre-2023 audits) are very much tied together.

@jperson1 jperson1 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants