Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey evaluation form system specs #295

Open
3 tasks
stepchud opened this issue Nov 26, 2024 · 0 comments
Open
3 tasks

Fix flakey evaluation form system specs #295

stepchud opened this issue Nov 26, 2024 · 0 comments
Labels

Comments

@stepchud
Copy link
Contributor

stepchud commented Nov 26, 2024

What/Why

As a developer, I want a stable CI build that doesn't give false negative results which slow development.
We have seen a few of the specs in spec/system/evaluation_form_spec.rb fail at random times on CircleCI and sometimes local dev.

Failing specs:

  • evaluation_form_spec.rb:262 # Evaluation Form update evaluation form page allows removing existing criteria
    • Occurences: **
  • evaluation_form_spec.rb:206 # Evaluation Form update evaluation form page allows editing of an existing form values
    • Occurences: *

These are from the same PR that was not updating eval forms:
Image
Image

Acceptance Criteria

  • the rspec step on CircleCI passes 5 times in a row when run from the start

NOTE: the "Re-run workflow from start" option has been observed to have more success than "Re-run workflow from failed" on CircleCI

@stepchud stepchud changed the title Fix flakey Evaluation Form system specs Fix flakey evaluation form system specs Nov 26, 2024
@stepchud stepchud added the task label Nov 26, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/03/24 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants