Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed 'connect to' to 'Add Device by IP' #1899

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Changed 'connect to' to 'Add Device by IP' #1899

merged 3 commits into from
Jan 3, 2025

Conversation

realAbhi-web
Copy link

@realAbhi-web realAbhi-web commented Dec 24, 2024 •
edited by ferdnyc
Loading

Changed the "connect to" option to "Add devices by IP"
image

Fixes #1886

@ferdnyc
Copy link
Member

ferdnyc commented Dec 31, 2024

@realAbhi-web Sorry for the delay in getting to this one.

I have two requests:

  1. Change the text from plural to singular — "Add device by IP" — because you can only add a single IP via the dialog that opens.
  2. Restore the ellipsis (…) at the end of the text. As I mention in Replace "Connect to ..." to "Add devices by IP" for clarity #1886 (comment), the GNOME Human Interface Guidelines indicate that an ellipsis should be shown since the menu option is an action which requires additional user input.

ferdnyc
ferdnyc requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested as indicated in previous comment.

@ferdnyc ferdnyc mentioned this pull request Jan 2, 2025
Closed
ferdnyc
ferdnyc approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great.

ferdnyc
ferdnyc approved these changes Jan 3, 2025
View reviewed changes
data/ui/preferences-window.ui Outdated Show resolved Hide resolved
@ferdnyc ferdnyc merged commit a75aa7d into GSConnect:main Jan 3, 2025
3 checks passed
@ferdnyc ferdnyc mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdnyc ferdnyc ferdnyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "Connect to ..." to "Add devices by IP" for clarity
2 participants
@realAbhi-web @ferdnyc