Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build script fails on j21 #15040

Closed
3 tasks done
bombcar opened this issue Dec 8, 2023 · 0 comments
Closed
3 tasks done

build script fails on j21 #15040

bombcar opened this issue Dec 8, 2023 · 0 comments
Labels
Comment to reopen Comment with a good reason to re-open and a Developer will consider it Status: stale Status: Triage Tasks awaiting triage. Removed once a dev confirms the issue as valid. Type: bugMinor

Comments

@bombcar
Copy link
Member

bombcar commented Dec 8, 2023

Your GTNH Discord Username

bombcar

Your Pack Version

2.4.2-252

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

be able to build gt5u on java 21

also happend to Grayduster: https://discord.com/channels/181078474394566657/401118216228831252/1182546813706846329

The Reality

It blows up in spotless - see https://scans.gradle.com/s/vzanrluvsxktc

Apparently this is fixed here diffplug/spotless#1920

BUT build.gradle says

id 'com.diffplug.spotless' version '6.13.0' apply false // 6.13.0 is the last jvm8 supporting version

Your Proposal

Well, I changed it to id 'com.diffplug.spotless' version '6.23.3' apply false // 6.13.0 is the last jvm8 supporting version and it build just fine https://scans.gradle.com/s/zpo4j6ivwfxug

So maybe we deprecate j8 compilation and move spotless forward, or is there a way to swap versions of spotless depending on the compiler?

do we ASM gradle?‽!‽

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@bombcar bombcar added Type: bugMinor Status: Triage Tasks awaiting triage. Removed once a dev confirms the issue as valid. labels Dec 8, 2023
@mitchej123 mitchej123 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
@mitchej123 mitchej123 added Status: stale Comment to reopen Comment with a good reason to re-open and a Developer will consider it labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comment to reopen Comment with a good reason to re-open and a Developer will consider it Status: stale Status: Triage Tasks awaiting triage. Removed once a dev confirms the issue as valid. Type: bugMinor
Projects
None yet
Development

No branches or pull requests

2 participants