GT5 Sleeping buff is not applied when Morpheus partial sleeping skips the night

[leumasme]

Your GTNH Discord Username

leumasme

Your Pack Version

2.6.1

Your Server

private server

Java Version

Java 21

Type of Server

Vanilla Forge

Your Expectation

When sleeping to skip the night, the GT5-Unofficial sleeping buff should kick in.
If the night was skipped but not all players slept, the buffs should apply to the players that did sleep.

The Reality

When not all players sleep and Morpheus kicks in to allow partial sleeping skipping the night
(Username is now sleeping. 1/2 (50%)),
the sleeping buffs are not applied to anyone.

Your Proposal

Fix Compatability between GT5 and Morpheus to apply sleeping buffs to the players that slept when Morpheus partial sleeping skips the night.

For reference:

• The GT5-Unofficial check is implemented here: https://github.com/GTNewHorizons/GT5-Unofficial/blob/ef900896ae43ea32adc6b9110402ffaf445b412d/src/main/java/gtPlusPlus/core/handler/events/PlayerSleepEventHandler.java#L59-L62
  • Checks if worldTime is divisible by 24000
  • This check was introduced in Don't give sleeping buff when player manually wake up GTplusplus#194
• The Morpheus night skipping is implemented here: https://github.com/Quetzi/Morpheus/blob/1.7.10/src/main/java/net/quetzi/morpheus/world/DefaultOverworldHandler.java and https://github.com/Quetzi/Morpheus/blob/1.7.10/src/main/java/net/quetzi/morpheus/SleepChecker.java#L61-L77
  • Morpheus skips the night by setting the dayTime to dayTime + timeToSunrise
  • This calculation probably results in some value that doesnt satisfy the GT5 check

Final Checklist

• I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
• I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
• I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

[leumasme]

More exactly, this seems to be caused by Morpheus checking the player sleep state and starting a new Day at the end of a tick, but not actually waking up the players.
When the next tick starts, the world time is first increased and then players are automatically woken up because it's already day - but at this point, its not the first tick of the day anymore.

This could be fixed by calling WorldServer.wakeAllPlayers at the end of SleepChecker.advanceToMorning.
This would also replace the world.provider.resetRainAndThunder(); call since WorldServer.wakeAllPlayers already does that.

It seems like there is no GTNH fork of Morpheus and the original project has no license.