Volcanus EU discount from coil applied after parallel

[52871299hzy]

Your GTNH Discord Username

Live_Learn

Your Pack Version

2.6.1

Your Server

SP

Java Version

Java 17

Type of Server

Single Player

Your Expectation

I'm trying to cook some Neutronium with Volcanus (advanced EBF), with Awakened Draconium coils (10801K) and 1 UHV energy hatch.

The recipe is 491520 EU/t with heat capacity 9000K, so the coil provides 2 EU discounts.

The actual EU/t for one ingot is 491520 *0.95^2 *0.9 = 399237 EU/t. So it should be able to do 5 parallel, as 5*399237 = 1996185 EU/t < 2097152 EU/t (1A UHV).

The Reality

The machine only does 4 parallel, consuming 1596949 EU/t. And even if I change to Eternal coils (13501K), it still does 4 parallel, consuming 1369184 EU/t, which is a lot less than 1A UHV.

And in 2.1.0.0 (which is really long ago), the same setup (Volcanus with 1 UHV hatch and coil with 10800K heat) can do 5 parallel.

It seems that the EU discounts from coils are calculated after parallel now?

Your Proposal

Calculate the parallels properly.

Final Checklist

• I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
• I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
• I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

[Vlamonster]

I found another instance of this issue:

At 1A@UMV with eternal coils, transcendent ingots receive a discount of 0.90 * 0.95^2 = 0.81. Blasting the ingots consumes 0.23A@UMV without the discount and 0.19A@UMV with the discount. Based on this, we should expect to see 5 parallels, but in practice, we only see 4.

[Vlamonster]

The issue appears to stem from using the default implementation of createParallelHelper, which is not correct for the Volcanus. A potential solution would be to override this method when creating the ProcessingLogic object.