Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord Auth not assigning username correctly #17067

Closed
mallowsc opened this issue Jun 22, 2023 · 10 comments · Fixed by #20900 · 4 remaining pull requests
Closed

Discord Auth not assigning username correctly #17067

mallowsc opened this issue Jun 22, 2023 · 10 comments · Fixed by #20900 · 4 remaining pull requests
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: plugin:users-permissions Source is plugin/users-permissions package status: confirmed Confirmed by a Strapi Team member or multiple community members

Comments

@mallowsc
Copy link
Contributor

  • Node.js version: 18.15.0
  • NPM version: 9.5.0
  • Strapi version: 4.11.2
  • Database: PostgresSQL
  • Operating system: Ubuntu Server
  • Is your project Javascript or Typescript: Javascript

Describe the bug

Discord is removing discriminator soon and Strapi does not update to the new username. In addition, users that have changed their Discord name have a #0 at the end of their name. This would not be needed. Another issue that would help is adding the Discord ID of a user to the user table.

Code snippets

strapi/packages/plugins/users-permissions/server/services/providers-registry.js

Line 58 in 553217b

const username = `${body.username}#${body.discriminator}`;

Additional context

Add any other context about the problem here.
@Boegie19 Boegie19 added issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: plugin:users-permissions Source is plugin/users-permissions package labels Jun 22, 2023
@github-project-automation github-project-automation bot moved this to To be reviewed (Open) in Developer Experience Squad Jun 22, 2023
@Boegie19 Boegie19 added the status: confirmed Confirmed by a Strapi Team member or multiple community members label Jun 22, 2023
@mallowsc
Copy link
Contributor Author

I added these lines of code to a branch I have but did not know the proper way to continue so I talked to Boegie and Boegie mentioned to submit an issue. The below is what I added to start.
image
image

@derrickmehaffy derrickmehaffy added the good first issue Good for newcomers label Jul 14, 2023
@ahzia
Copy link

ahzia commented Sep 14, 2023

@Boegie19 @derrickmehaffy I want to work on this issue and create a PR, Is it valid?

@derrickmehaffy
Copy link
Member

Sure, please feel free

@gitstart gitstart mentioned this issue Sep 20, 2023
Closed
@akay41024 akay41024 mentioned this issue Sep 30, 2023
Closed
@v-a14
Copy link

v-a14 commented Oct 26, 2023

@Boegie19 @derrickmehaffy I want to work on this issue and create a PR, Is it valid?

Havw your pr merged ?

@Aditya8840
Copy link

I want to work on this issue, if still open

@mallowsc
Copy link
Contributor Author

Hi @derrickmehaffy . I wanted to follow up on this. I know it's been awhile and fix 18115 was abandoned due to the previous issues with 4.15. Do you think we could get this implemented soon?

@derrickmehaffy
Copy link
Member

I requested some changes to the PR author as is we can't merge that but there are few things that need to be changed.

@mallowsc
Copy link
Contributor Author

It looks like we are back to square one. When I get a chance, is it possible that I can look at correcting this?

@derrickmehaffy
Copy link
Member

It looks like we are back to square one. When I get a chance, is it possible that I can look at correcting this?

Sure please feel free to submit a PR

@mallowsc mallowsc mentioned this issue Jul 29, 2024
Merged
@mallowsc
Copy link
Contributor Author

10-4. I did this. Hopefully I did this correctly.

derrickmehaffy added a commit that referenced this issue Aug 26, 2024
@derrickmehaffy
Merge pull request #20900 from mallowsc/develop
dcd10ea 
Fix: #17067 Discord Auth not assigning username correctly
@github-project-automation github-project-automation bot moved this from To be reviewed (Open) to Fixed/Shipped in Developer Experience Squad Aug 26, 2024
This was referenced Sep 20, 2024
Open
Open
Open
@VolkovDani VolkovDani mentioned this issue Sep 24, 2024
Open
@zazikell zazikell mentioned this issue Sep 24, 2024
Open
@zemelko zemelko mentioned this issue Sep 24, 2024
Open
@pinyaevv pinyaevv mentioned this issue Sep 24, 2024
Open
@zazikell zazikell mentioned this issue Sep 25, 2024
Open
This was referenced Sep 25, 2024
Open
Open
@pinyaevv pinyaevv mentioned this issue Sep 25, 2024
Open
@VolkovDani VolkovDani mentioned this issue Sep 25, 2024
Open
@GabsBaquie GabsBaquie mentioned this issue Sep 26, 2024
Open
This was referenced Sep 26, 2024
Open
Open
@VolkovDani VolkovDani mentioned this issue Sep 26, 2024
Open
@zazikell zazikell mentioned this issue Sep 26, 2024
Open
@pinyaevv pinyaevv mentioned this issue Sep 26, 2024
Open
@zazikell zazikell mentioned this issue Sep 27, 2024
Open
@pinyaevv pinyaevv mentioned this issue Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@zazikell zazikell mentioned this issue Oct 1, 2024
Open
This was referenced Oct 1, 2024
Open
Open
This was referenced Oct 1, 2024
Open
Open
@zazikell zazikell mentioned this issue Oct 2, 2024
Open
@VolkovDani VolkovDani mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: plugin:users-permissions Source is plugin/users-permissions package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
Developer Experience Squad
Status: Fixed/Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: #17067 Discord Auth not assigning username correctly mallowsc/fix-17067-mallowsc
[Snyk] Upgrade: , , zemelko/hexlet-ci-app
[Snyk] Upgrade: , , zemelko/hexlet-ci-app
[Snyk] Upgrade: , , zemelko/hexlet-ci-app
[Snyk] Upgrade @strapi/plugin-users-permissions from 4.2.3 to 4.25.9 VolkovDani/hexlet-ci-app
[Snyk] Upgrade @strapi/plugin-users-permissions from 4.2.3 to 4.25.9 zazikell/hexlet-ci-app
[Snyk] Upgrade @strapi/strapi from 4.15.0 to 4.25.9 zemelko/hexlet-ci-app
[Snyk] Upgrade @strapi/plugin-users-permissions from 4.2.3 to 4.25.9 pinyaevv/hexlet-ci-app
[Snyk] Upgrade @strapi/plugin-users-permissions from 4.2.3 to 4.25.9 zazikell/hexlet-ci-app
[Snyk] Upgrade @strapi/plugin-users-permissions from 4.2.3 to 4.25.9 zemelko/hexlet-ci-app
6 participants
@derrickmehaffy @ahzia @Boegie19 @v-a14 @Aditya8840 @mallowsc