saveOutputs := false still creating secret

[oskar-s9s]

https://github.com/isaaguilar/terraform-operator/blob/master/pkg/controllers/terraform_controller.go#L408

Shouldn't this be true by default?

It will create the secret but, the secret will contain no data.
It's very misleading.

[isaaguilar]

Hi @oskar-s9s thanks for asking. I'm not sure if users want that secret to contain the outputs by default. I see one of two options, (a) no secret is created to avoid confusion , or (b) outputs are added by default instead.

I'm going to opt for (a). I don't like the idea of automatically adding the outputs without the users explicit consent.

Both cases means the code needs to be fixed to not create a secret when saveOutputs is false.

[oskar-s9s]

Hello, This sounds great :-) thank you very much.