Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case for issue #835 no longer tests what it's supposed to test #1329

Closed
brianhuffman opened this issue Feb 28, 2022 · 1 comment
Closed

Test case for issue #835 no longer tests what it's supposed to test #1329

brianhuffman opened this issue Feb 28, 2022 · 1 comment
Labels
low-hanging fruit For issues that should be easy to fix

Comments

@brianhuffman
Copy link
Contributor

Issue #835 is supposed to test that the pretty printer can correctly parenthesize type expressions like SignedCmp (Float 5 11). Test issue835.icry (created in e48e9f8) tested this by trying to evaluate an expression that causes a type error; the error message said that SignedCmp (Float 5 11) was an unsolvable constraint.

However, since bfad11b, the error message is changed and no longer requires parentheses. We should either update the regression test so that it tests the type pretty printer, or remove it.
@brianhuffman brianhuffman added the low-hanging fruit For issues that should be easy to fix label Feb 28, 2022
This was referenced Aug 22, 2022
Closed
Closed
Closed
Merged
@RyanGlScott
Copy link
Contributor

Fixed in #1417.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-hanging fruit For issues that should be easy to fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianhuffman @RyanGlScott