Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selector syntax regression #926

Closed
robdockins opened this issue Oct 2, 2020 · 1 comment · Fixed by #938
Closed

selector syntax regression #926

robdockins opened this issue Oct 2, 2020 · 1 comment · Fixed by #938
Labels
bug Something not working correctly parser Issues with lexing or parsing.
Milestone

Comments

@robdockins
Copy link
Contributor

Recent changes in the selector syntax seem to have broken some previous code. This is from the saw-script repository, in the example ECDSA verification.

https://github.com/GaloisInc/saw-script/blob/6247f9ac936628cb6f9e74f33738e059eb32582b/examples/ecdsa/cryptol-spec/p384_ec_mul.cry#L212

Maybe we accidentally removed prime characters from the lexical syntax for selectors?

$ ./cry run ~/code/saw-script/examples/ecdsa/cryptol-spec/p384_ec_mul.cry
┏━╸┏━┓╻ ╻┏━┓╺┳╸┏━┓╻
┃  ┣┳┛┗┳┛┣━┛ ┃ ┃ ┃┃
┗━╸╹┗╸ ╹ ╹   ╹ ┗━┛┗━╸
version 2.9.1.99 (96fcce9, modified)
https://cryptol.net  :? for help

Parse error at /Users/rdockins/code/saw-script/examples/ecdsa/cryptol-spec/p384_ec_mul.cry:212:35--212:44
  malformed selector: .tma2_c0'
@robdockins robdockins added the bug Something not working correctly label Oct 2, 2020
@yav
Copy link
Member

yav commented Oct 2, 2020

A yes, I forgot about those.

@yav yav added this to the 2.10.0 milestone Oct 6, 2020
@brianhuffman brianhuffman added the parser Issues with lexing or parsing. label Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something not working correctly parser Issues with lexing or parsing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants