Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of isaModifyJumpTarget #33

Open
travitch opened this issue Mar 27, 2020 · 0 comments
Open

Change the type of isaModifyJumpTarget #33

travitch opened this issue Mar 27, 2020 · 0 comments

Comments

@travitch
Copy link
Contributor

Currently, neither implementation ever returns Nothing and just panics if a non-jump is passed in or if the required jump is not realizable. There is a redundant check at the call sites if we want it to be able to just panic.

We can either make it "total" (modulo the panics) or just return 'Nothing' when we currently panic and push the panic to the caller. There is additional arch-specific information available to provide more accurate panics in the backend implementations, so that might be a useful concern. On the other hand, the call site (mapJumpAddress) is in a context that could turn the failure into an exception that could be recoverable by a renovate client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant