Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary unpacking and repacking of Text values #1269

Closed
brianhuffman opened this issue Apr 27, 2021 · 3 comments
Closed

Avoid unnecessary unpacking and repacking of Text values #1269

brianhuffman opened this issue Apr 27, 2021 · 3 comments
Labels
tech debt Issues that document or involve technical debt

Comments

@brianhuffman
Copy link
Contributor

We should look over all occurrences of Text.pack and Text.unpack in the codebase; many of them are probably unnecessary. We should be able to keep values in type Text as much as possible, and try not to ever convert them to type String.
@brianhuffman brianhuffman added the tech debt Issues that document or involve technical debt label Apr 27, 2021
@RyanGlScott
Copy link
Contributor

See also #1260.

@brianhuffman
Copy link
Contributor Author

I have a patch for #1260 in preparation now; this ticket is so I don't forget all the other uses of Text.pack and Text.unpack that I've encountered along the way.

This was referenced Apr 27, 2021
Merged
Merged
@brianhuffman
Copy link
Contributor Author

#1281 probably took care of enough String/Text conversions for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Issues that document or involve technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianhuffman @RyanGlScott