Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding regression tests requires too much work #314

Closed
brianhuffman opened this issue Oct 10, 2018 · 4 comments
Closed

Adding regression tests requires too much work #314

brianhuffman opened this issue Oct 10, 2018 · 4 comments
Assignees
Labels
priority High-priority issues
Milestone

Comments

@brianhuffman
Copy link
Contributor

We have a test suite in the intTests directory, but its growth is hindered by how cumbersome it is to add tests. Adding a test requires creating a subdirectory with multiple files, including a shell script. I would like to have a directory where I could add a new test by simply creating a new .saw file (and possibly an expected-output file or other supporting files as necessary).

@atomb atomb added the priority High-priority issues label Apr 1, 2019
@atomb atomb added this to the 0.3 milestone Apr 1, 2019
@atomb atomb added priority High-priority issues and removed priority High-priority issues labels Apr 2, 2019
@atomb atomb removed this from the 0.3 milestone Apr 22, 2019
@atomb atomb added this to the 1.0 milestone Jun 4, 2019
@atomb atomb modified the milestones: 0.5, 0.6 Apr 20, 2020
@ChrisEPhifer ChrisEPhifer self-assigned this Aug 7, 2020
@ChrisEPhifer
Copy link
Member

This is a pretty old ticket, but probably one of the items in the 0.6 milestone I'm best equipped to work on without a bunch of time spent staring at the code for the internals. I'm not sure I'll have something completely done by the end of next week (I'm taking the last two weeks of August off to move), but I'll take a crack at implementing something a little bit easier to work with than what we currently have. I'll likely need some assistance integrating whatever I come up with into the CI system, since I don't have much experience with CI/CD systems in general, but that's definitely not an immediate concern.

@kquick
Copy link
Member

kquick commented Aug 7, 2020

BTW, @ChrisEPhifer , I'm hoping to land #796 soon, which means the tests are run as part of a standard cabal test invocation. That should put it into scope for most CI scenarios without requiring extra work. This might let you use something like tasty-golden to extend the current mechanisms.

@ChrisEPhifer
Copy link
Member

Ah, awesome! Thanks for pointing that out.

@atomb atomb modified the milestones: 0.6, 0.7 Aug 31, 2020
@brianhuffman
Copy link
Contributor Author

My current habit is to use some existing saw-script tests as templates whenever I want to create a new regression test; that works well enough, so I'm closing the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority High-priority issues
Projects
None yet
Development

No branches or pull requests

4 participants