Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_unint proof tactics don't work for constants defined in .saw files #377

Closed
brianhuffman opened this issue Feb 28, 2019 · 1 comment
Closed
Assignees

Comments

@brianhuffman
Copy link
Contributor

We have two ways to represent a defined constant in a saw-core Term: First there is GlobalDef, which refers to a definition in a saw-core module; occurrences are created with scGlobalDef or scGlobalApply. Second there is Constant, which is defined dynamically with scConstant.

As it turns out, the uninterpreted function feature of saw-script proof tactics only works with Constant terms, and not GlobalDef ones. So, for example, while it is possible to treat the cryptol pmod and pmult operators as uninterpreted (as they are defined in the Cryptol prelude and translated with scConstant) we can't make >>> uninterpreted (because it's a Cryptol primitive that is translated with scGlobalDef).

We should make all of this more consistent. We could make the saw-core simulator backend handle GlobalDef the same way as Constant. Or else we could just unify GlobalDef and Constant, because we don't really need both.

@brianhuffman
Copy link
Contributor Author

Fixed by GaloisInc/saw-core#118, which was included in saw-script by PR #1020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant