Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Better Line Number Feedback #456

Closed
pedrotst opened this issue May 21, 2019 · 1 comment
Closed

Feature Request: Better Line Number Feedback #456

pedrotst opened this issue May 21, 2019 · 1 comment
Assignees
Labels
better-in-python Will be fixed by switching to python frontend topics: error-messages Issues involving the messages SAW produces on error type: enhancement Issues describing an improvement to an existing feature or capability wontfix Closed issues that we decided not to fix, but are still potentially relevant

Comments

@pedrotst
Copy link
Contributor

pedrotst commented May 21, 2019

Consider this minor modification to examples/llvm/dotprod_struct-crucible.saw

...
let dotprod_spec n = do {
...
    let yval = crucible_struct [ ysp, nt ]; // line 20
    xp <- alloc_init (llvm_struct "struct.vec_t") xval;
    (yyp, yp) <- alloc_init (llvm_struct "struct.vec_t") yval; // <--- Bug introduced
...
};
...

Instead of reporting the bug on line 22, it reports the type mismatch on line 20, which makes it a lot harder to find the issue.

Loading file ".../examples/llvm/dotprod_struct-crucible.saw"
.../saw-script/examples/llvm/dotprod_struct-crucible.saw:20:9-20:13: 
type mismatch: CrucibleSetup (t.26, t.27) and CrucibleSetup SetupValue

 at "dotprod_spec" (.../saw-script/examples/llvm/dotprod_struct-crucible.saw:15:5-15:17)
type mismatch: (t.26, t.27) and SetupValue at "dotprod_spec" 
(.../saw-script/examples/llvm/dotprod_struct-crucible.saw:15:5-15:17)

Please find attached all the files
dotprod_bug.tar.gz

@langston-barrett langston-barrett added type: enhancement Issues describing an improvement to an existing feature or capability topics: error-messages Issues involving the messages SAW produces on error labels May 21, 2019
@atomb atomb added this to the 1.0 milestone Jun 4, 2019
@chameco chameco self-assigned this Apr 8, 2020
@atomb atomb modified the milestones: 0.5, 0.6 Apr 27, 2020
@brianhuffman brianhuffman added the better-in-python Will be fixed by switching to python frontend label May 15, 2020
@brianhuffman
Copy link
Contributor

It might not be worth putting much effort into this, as we are thinking about transitioning to the new python-based language frontend.

@atomb atomb modified the milestones: 0.6, 0.7 Aug 20, 2020
@atomb atomb removed this from the 0.7 milestone Oct 16, 2020
@atomb atomb added the wontfix Closed issues that we decided not to fix, but are still potentially relevant label Oct 16, 2020
@atomb atomb closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-in-python Will be fixed by switching to python frontend topics: error-messages Issues involving the messages SAW produces on error type: enhancement Issues describing an improvement to an existing feature or capability wontfix Closed issues that we decided not to fix, but are still potentially relevant
Projects
None yet
Development

No branches or pull requests

5 participants