Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIKE proofs cannot be reproduced locally #738

Closed
robdockins opened this issue Jun 12, 2020 · 1 comment
Closed

SIKE proofs cannot be reproduced locally #738

robdockins opened this issue Jun 12, 2020 · 1 comment
Labels
priority High-priority issues tech debt Issues that document or involve technical debt test assets Issues involving test programs or other test assets tooling: CI Issues involving CI/CD scripts or processes

Comments

@robdockins
Copy link
Contributor

With GaloisInc/s2n checked out to hash eae05a158032468fa18de0d8a9132c310abaa4f8, I attempt the following interaction on OSX 10.15.5

$ export CLANG=/usr/local/Cellar/llvm\@7/7.1.0_1/bin/clang
$ export LLVMLINK=/usr/local/Cellar/llvm\@7/7.1.0_1/bin/llvm-link
$ make -C tests/saw sike

This eventually results in the following output:

patch s2n/pq-crypto/sike_r2/ec_isogeny.c sike_r2/patch/ec_isogeny.c.patch
(Stripping trailing CRs from patch.)
patching file s2n/pq-crypto/sike_r2/ec_isogeny.c
Hunk #1 FAILED at 304.
1 out of 1 hunk FAILED -- saving rejects to file s2n/pq-crypto/sike_r2/ec_isogeny.c.rej
make[1]: *** [bitcode/sike_r2_llvm.bc] Error 1
make: *** [sike_r2_patched_bitcode] Error 2

Instead, I expect to be able to run the SAW proofs locally to diagnose problems.

@robdockins robdockins added tech debt Issues that document or involve technical debt tooling: test infrastructure Issues involving test infrastructure or test execution, or making SAW more testable priority High-priority issues labels Jun 12, 2020
@atomb atomb added the devops label Jul 30, 2021
@chameco
Copy link
Contributor

chameco commented Apr 25, 2022

I believe this was fixed in #823 - our CI configuration shares the Docker containers used in s2nTests/, so entering that directory and running make saw-script && make sike should reproduce any failures (well, failures unrelated to Actions resource limits).

@chameco chameco closed this as completed Apr 25, 2022
@sauclovian-g sauclovian-g added tooling: CI Issues involving CI/CD scripts or processes test assets Issues involving test programs or other test assets and removed devops tooling: test infrastructure Issues involving test infrastructure or test execution, or making SAW more testable labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority High-priority issues tech debt Issues that document or involve technical debt test assets Issues involving test programs or other test assets tooling: CI Issues involving CI/CD scripts or processes
Projects
None yet
Development

No branches or pull requests

4 participants