Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java extraction examples broken #994

Closed
robdockins opened this issue Jan 8, 2021 · 2 comments
Closed

java extraction examples broken #994

robdockins opened this issue Jan 8, 2021 · 2 comments
Assignees
Milestone

Comments

@robdockins
Copy link
Contributor

When running the integration tests with SAW 0.7 and on master.

$ saw-0.7 -j /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre/lib/rt.jar:/Users/rdockins/code/saw-script/intTests/jars/org.sat4j.core.jar:/Users/rdockins/code/saw-script/intTests/../deps/jvm-verifier/jars/bcprov-jdk16-145.jar:/Users/rdockins/code/saw-script/intTests/../deps/jvm-verifier/jars/galois.jar arrays.saw


[18:05:00.192] Loading file "/Users/rdockins/code/saw-script/intTests/test_examples/tmp/examples/java/arrays.saw"
[18:05:00.194] Type errors:
  /Users/rdockins/code/saw-script/intTests/test_examples/tmp/examples/java/arrays.saw:49:14-49:45: Type Mismatch, expected: JavaSetup () -> t.40 but got: TopLevel Term
 at "main" (/Users/rdockins/code/saw-script/intTests/test_examples/tmp/examples/java/arrays.saw:40:5-40:9)
Term is not a function at "main" (/Users/rdockins/code/saw-script/intTests/test_examples/tmp/examples/java/arrays.saw:40:5-40:9)
(maybe a function is applied to too many arguments?)

  /Users/rdockins/code/saw-script/intTests/test_examples/tmp/examples/java/arrays.saw:48:15-48:45: Type Mismatch, expected: JavaSetup () -> t.36 but got: TopLevel Term
 at "main" (/Users/rdockins/code/saw-script/intTests/test_examples/tmp/examples/java/arrays.saw:40:5-40:9)
Term is not a function at "main" (/Users/rdockins/code/saw-script/intTests/test_examples/tmp/examples/java/arrays.saw:40:5-40:9)
(maybe a function is applied to too many arguments?)

It seems java_extract was renamed to jvm_extract without actually updating the examples in which it's used. These are different functions and work differently.

@RyanGlScott
Copy link
Contributor

By sheer coincidence, I discovered this recently and complained about it to @atomb, who claims to have a fix in the works :)

@atomb
Copy link
Contributor

atomb commented Jan 8, 2021

Yeah, I'll be merging a fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants