Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CVC{4,5} natively on Windows #32

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Build CVC{4,5} natively on Windows #32

merged 2 commits into from
Mar 15, 2023

Conversation

RyanGlScott
Copy link
Contributor

@RyanGlScott RyanGlScott commented Mar 10, 2023

This patch:

  • Upgrades CVC5 to version 1.0.5, which contains several key bugfixes and a new --win64-native flag, which allows CVC5 to be build natively on Windows.
  • Backports the --win64-native flag to CVC4, thereby allowing it to be built natively as well.
  • Tweaks the CI configuration to clean up how Python dependencies are installed, which are important to building CVC4 and CVC5.

Fixes #4. By upgrading the CVC5 version, this also fixes #31.

@RyanGlScott RyanGlScott force-pushed the cvc5-windows-native branch 8 times, most recently from b9c9330 to 990d2e5 Compare March 13, 2023 21:16
@RyanGlScott RyanGlScott marked this pull request as ready for review March 13, 2023 21:17
@RyanGlScott RyanGlScott marked this pull request as draft March 14, 2023 00:28
@RyanGlScott RyanGlScott marked this pull request as ready for review March 14, 2023 01:34
@RyanGlScott RyanGlScott marked this pull request as draft March 14, 2023 01:57
This patch:

* Upgrades CVC5 to version 1.0.5, which contains several key bugfixes and a new
  `--win64-native` flag, which allows CVC5 to be build natively on Windows.
* Backports the `--win64-native` flag to CVC4, thereby allowing it to be built
  natively as well.
* Tweaks the CI configuration to clean up how Python dependencies are installed,
  which are important to building CVC4 and CVC5.

Fixes #4. By upgrading the CVC5 version, this also fixes #31.
Unfortunately, using a native Windows version of Python causes Z3's
`mk_make.py` script to generate a `Makefile` tailored specifically for Visual
Studio, which is annoying to deal with in GitHub Actions. We instead use Z3's
CMake/Ninja-based build, which avoids this.
@RyanGlScott RyanGlScott marked this pull request as ready for review March 14, 2023 03:08
@RyanGlScott RyanGlScott merged commit 0d081e8 into main Mar 15, 2023
@RyanGlScott RyanGlScott deleted the cvc5-windows-native branch March 15, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade CVC5 version when fix for cvc5/cvc5#8900 is released Get CVC4 building on Windows
1 participant