You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
When an initial screenshot is taken with happo of a new example, there is no indication of whether or not any of the content is rendered outside of the viewport. The screenshot just stretches to display the whole content. It would be pretty cool if there were a border or something similar to indicate where the actual viewport was.
This is a good idea. I think the best way to apply this would be on the review page, dynamically. It looks like we're only passing viewportName to that view, so doing this would be a two-fold thing:
First, make sure that runVisualDiffs saves the viewport width along with the name. Somewhere around here:
When an initial screenshot is taken with happo of a new example, there is no indication of whether or not any of the content is rendered outside of the viewport. The screenshot just stretches to display the whole content. It would be pretty cool if there were a border or something similar to indicate where the actual viewport was.
fyi: @lencioni
The text was updated successfully, but these errors were encountered: