Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

No way to tell when a new screenshot is rendering outside the viewport #206

Open
majapw opened this issue Jun 1, 2017 · 1 comment
Open

Comments

@majapw
Copy link

majapw commented Jun 1, 2017

When an initial screenshot is taken with happo of a new example, there is no indication of whether or not any of the content is rendered outside of the viewport. The screenshot just stretches to display the whole content. It would be pretty cool if there were a border or something similar to indicate where the actual viewport was.

fyi: @lencioni

@trotzig
Copy link
Contributor

trotzig commented Jun 2, 2017

This is a good idea. I think the best way to apply this would be on the review page, dynamically. It looks like we're only passing viewportName to that view, so doing this would be a two-fold thing:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants