Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

config.get(...).uploader is not a function #211

Open
lencioni opened this issue Jun 22, 2017 · 1 comment
Open

config.get(...).uploader is not a function #211

lencioni opened this issue Jun 22, 2017 · 1 comment

Comments

@lencioni
Copy link
Contributor

I'm working on updating a project from happo 4 to happo 5, and when it tries to upload after running I end up with the following error:

TypeError: config.get(...).uploader is not a function
    at /home/travis/build/org/project/node_modules/happo-viewer/lib/uploadLastResult.js:92:35
    at Promise (<anonymous>)
    at uploadLastResult (/home/travis/build/org/project/node_modules/happo-viewer/lib/uploadLastResult.js:82:12)
    at Command.<anonymous> (/home/travis/build/org/project/node_modules/happo/lib/cli.js:74:3)
    at Command.listener (/home/travis/build/org/project/node_modules/commander/index.js:301:8)
    at emitTwo (events.js:125:13)
    at Command.emit (events.js:213:7)
    at Command.parseArgs (/home/travis/build/org/project/node_modules/commander/index.js:615:12)
    at Command.parse (/home/travis/build/org/project/node_modules/commander/index.js:458:21)
    at cli (/home/travis/build/org/project/node_modules/happo/lib/cli.js:97:15)

I haven't dug in yet but I figured I'd log it here for now.

"happo": "5.0.0-rc.3",
"happo-target-firefox": "5.0.0-rc.6",
@lencioni
Copy link
Contributor Author

I'm pretty sure this was because I forgot to add uploader to my config file when updating. We should add a check and give a helpful error message in this scenario.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant