Receiver does not get memo for intraledger payments

[Extheoisah]

When I receive an intraledger payment, the memo field in the transactions data that is returned from the backend is null even when the sender sets a memo/note when making the payment. The sender has the memo in his/her transaction details but not the receiver.

We might want to also show the note that was set by the sender, so we need to send the memo field as part of the transaction data. The frontend already expects this data here https://github.com/GaloyMoney/galoy-mobile/blob/ace5b5de465720f256b4730d5001ed6c8cdca747/app/components/transaction-item/transaction-item.tsx#L76

[Marvel-Ib]

Hi @Extheoisah I would love to take up the issue .

just to clarify the receiver does not get the memo set by the sender at the moment and the aim is to ensure whenever a sender sets a memo/note the receiver is able to see the memo/note as well.

[nicolasburtey]

hi @Marvel-Ib. thanks for your message and wanting to contribute to our repo. it's probably a complex issue. there are privacy implication we need to narrow down here.

I think @vindard may have more context around the memo issue, but if you want to tackle some issues to get started with our repo, there might be easier one

[vindard]

Agree with @nicolasburtey, there might be easier issues to tackle. If we want to do this properly we'd likely need multiple "memo" fields on a single entry, some of which would be walletId-private, e.g.:

• privateMemo
• sharedMemo
• memoFromLnInvoice

[openoms]

Despite adding a note to the invoice (which correctly shows up on the sender side) the memo field is not being stored on the receiver side neither for intraLedger nor for ligthning transactions.
Also noted in the review here: getAlby/lightning-browser-extension#2887 (comment)