chore(notifications): make push msg optional #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
UncleSamtoshi
commented
Apr 23, 2024
•
UncleSamtoshi
commented
- Make push optional for notifications
| &self, | ||
| _locale: GaloyLocale, | ||
| ) -> Option<LocalizedStatefulMessage> { | ||
| None |
There was a problem hiding this comment.
This is the wrong way. The interface should encapsulate the contract of the should method is true we always return the message. Anything else is an implementation bug that is ok to crash (since it should never happen).
So if you refactor remove the other options instead of adding this one.
There was a problem hiding this comment.
Makes sense, I will make the change
UncleSamtoshi
force-pushed
the
notifications-optional-channels
branch
from
1820e64 to
dc0423d
Compare
bodymindarts
approved these changes
Apr 23, 2024
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.